New notification window ignores position setting
Reported by Alan James | March 17th, 2010 @ 06:35 PM | in Version 0.10
I pulled the source from git today to check out the new notification window and noticed that it ignores the notification position setting.
Finding the bug wasn't difficult and the tiny patch to /vendors/purrjs.js is attached.
Comments and changes to this ticket
-
Alan James March 17th, 2010 @ 06:39 PM
I didn't try to find out why but the position option had to be specified as opts.position and not put in quotes like the message and icon options. Do those options work or should they be changed too ?
-
-
-
Ed Finkler May 10th, 2010 @ 01:26 PM
- no changes were found...
-
Ron DeVera June 17th, 2010 @ 10:17 PM
- State changed from “new” to “resolved”
This wasn't a bug in the vendor code, so we shouldn't patch it. The Spaz call to
PurrJS.notifywas using the option keywhere, but the PurrJS API calls forposition.http://github.com/funkatron/spaz-desktop-air/commit/5032b555e0386ab...
Please Sign in or create a free account to add a new ticket.
With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.
Create new ticket
Create your profile
Help contribute to this project by taking a few moments to create your personal profile. Create your profile ยป
The Spaz Desktop project
Alan James
Ed Finkler