Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

Make max number of timeline tweets requested in a refresh configurable

#30

When moving from 0.8.x to the bleeding-edge builds / running from trunk, I had a big issue with the maximum number of tweets that would get returned in a refresh. In 0.8.x (and before), the maximum was 200; it's now only 50. For normal use, this is ok, but it's very annoying when Spaz refreshes the first time after a computer has been asleep.

After investigating this a bit, this is because the relevant function in Spazcore (Spaztwit.prototype.getHomeTimeline) defaults to retrieving 50 if no options are passed in. Following the chain up, we don't pass in any options in from spaz.timelines.js.

As a stopgap measure, I've edited the Spazcore function to pull back 200 tweets. This change would work as a stopgap measure, but it would probably make more sense to ultimately move it to the user preferences where it could be tweaked (within reasonable limits.)

Reported by Ryan Adams · March 18th, 2010 @ 08:57 PM

State: resolved
Milestone: Version 0.10
Assigned to: Ed Finkler Ed Finkler

Activity

  1. Ed Finkler
    Ed Finkler
    • Milestone set to Version 0.10

    April 14th, 2010 @ 08:17 PM

  2. alab
    alab

    Ok today i will work on that one, and implement the pref settings, and passing the prefs to get*Timeline.
    Additionally i will introduce a pref setting which is not adjustable for the max-values
    to each timeline-view which may differ by the twitter-api
    i.e. user-timeline <= 200/page && search <= 100/page

    May 8th, 2010 @ 12:17 PM

  3. alab
    alab

    Added diff Attachement, which prepares setting the tweets/page for the
    UserTimeline, FriendsTimeline and Search.

    http://apiwiki.twitter.com/Twitter-REST-API-Method%3A-GET-list-stat...
    The GET list statuses twitter api allows setting a per_page parameter as well,
    this should be implemented into spazcore.

    For the moment i did not touch the prefs

    'timeline-maxentries-dm': 25,
'timeline-maxentries-reply': 50,
'timeline-loadonstartup': true,
'timeline-friends-getcount': 40,
'timeline-replies-getcount': 20,
'timeline-dm-getcount': 10,

    But since i took another naming schema like

    'timeline-home-pager-count-max': 200, //max allowed by twitter api
'timeline-home-pager-count': 50, //setting via adjustable prefs

    they should be adjusted where needed.

    May 8th, 2010 @ 04:13 PM

  4. Ed Finkler
    Ed Finkler
    • State changed from new to resolved

    May 8th, 2010 @ 04:52 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.