Lighthouse has a new layout. Prefer the old one? Return to the old layout, and switch back any time from the link at the top of each page.

New notification window ignores position setting

#28

I pulled the source from git today to check out the new notification window and noticed that it ignores the notification position setting.

Finding the bug wasn't difficult and the tiny patch to /vendors/purrjs.js is attached.

Reported by Alan James · March 17th, 2010 @ 06:35 PM

State: resolved
Milestone: Version 0.10
Assigned to: Ron DeVera Ron DeVera

Activity

  1. Alan James
    Alan James

    I didn't try to find out why but the position option had to be specified as opts.position and not put in quotes like the message and icon options. Do those options work or should they be changed too ?

    March 17th, 2010 @ 06:39 PM

  2. Ed Finkler
    Ed Finkler
    • Milestone set to Version 0.10

    April 14th, 2010 @ 08:17 PM

  3. Ed Finkler
    Ed Finkler

    May 10th, 2010 @ 01:21 PM

  4. Ed Finkler
    Ed Finkler
    • No changes were found…

    May 10th, 2010 @ 01:26 PM

  5. Ron DeVera
    Ron DeVera
    • State changed from new to resolved

    This wasn't a bug in the vendor code, so we shouldn't patch it. The Spaz call to PurrJS.notify was using the option key where, but the PurrJS API calls for position.

    http://github.com/funkatron/spaz-desktop-air/commit/5032b555e0386ab...

    June 17th, 2010 @ 10:17 PM

Please Sign in or create a free account to add a new ticket.

With your very own profile, you can contribute to projects, track your activity, watch tickets, receive and update tickets through your email and much more.